The updater is very buggy

Hello

A) is not related to updater, but to nuci. This is output by one of the libraries it uses and it is completely harmless (it just says we don’t support some fancy feature of the netconf protocol).

C), well, it was not us who did the locking wrong. Opkg does it a bit wrong, and the script had it 100% wrong. We decided that fixing some third-party script (that is not probably supposed to touch that lock in the first place anyway) is not worth bringing the small bug into our code.

D) It’s not a real memory leak. It’s just the memory usage is higher than we expected it would be and we will have a look into it. But as the updater doesn’t run all the time (it is always just run and it terminates), this is not a big problem (and it wouldn’t be even if there were memory leaks ‒ the memory is returned on termination).

And I can assure you this is not reinventing the wheel. We looked around and discovered nothing has the features we need. And we did the thing with a wrapper around opkg, you can have a look at the master branch of https://gitlab.labs.nic.cz/turris/updater/tree/master ‒ you are especially interested in the files updater.hs, updater-worker.sh and updater-utils.sh. Besides being a really complex and unmaintainable monster, it didn’t meet all the needs. So yes, it was worth it.

1 Like